Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for opaque configs with examples #54

Merged
merged 5 commits into from
Aug 30, 2024
Merged

Add support for opaque configs with examples #54

merged 5 commits into from
Aug 30, 2024

Conversation

klueska
Copy link
Contributor

@klueska klueska commented Aug 22, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 22, 2024
@k8s-ci-robot k8s-ci-robot requested review from bart0sh and pohly August 22, 2024 20:37
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 22, 2024
@klueska klueska marked this pull request as draft August 22, 2024 20:38
@klueska klueska force-pushed the add-custom-config branch 5 times, most recently from ae336e3 to 07a58f5 Compare August 22, 2024 21:17
@klueska klueska marked this pull request as ready for review August 22, 2024 21:17
@klueska klueska changed the title WIP: Add support for custom configs with examples Add support for opaque configs with examples Aug 22, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2024
@klueska klueska force-pushed the add-custom-config branch from 07a58f5 to d94ce0e Compare August 22, 2024 21:20
@klueska klueska requested review from bart0sh, elezar and byako and removed request for bart0sh August 22, 2024 21:21
@klueska klueska force-pushed the add-custom-config branch 2 times, most recently from 71d88d3 to 4b19be4 Compare August 22, 2024 21:32
elezar
elezar reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @klueska. Some minor questions.

README.md Outdated Show resolved Hide resolved
cmd/dra-example-kubeletplugin/cdi.go Outdated Show resolved Hide resolved
cmd/dra-example-kubeletplugin/cdi.go Show resolved Hide resolved
cmd/dra-example-kubeletplugin/state.go Outdated Show resolved Hide resolved
cmd/dra-example-kubeletplugin/state.go Outdated Show resolved Hide resolved
cmd/dra-example-kubeletplugin/state.go Outdated Show resolved Hide resolved
cmd/dra-example-kubeletplugin/state.go Outdated Show resolved Hide resolved
cmd/dra-example-kubeletplugin/state.go Outdated Show resolved Hide resolved
cmd/dra-example-kubeletplugin/state.go Outdated Show resolved Hide resolved
demo/gpu-test4.yaml Show resolved Hide resolved
@klueska klueska force-pushed the add-custom-config branch 2 times, most recently from d09b016 to e11dab3 Compare August 23, 2024 11:59
elezar
elezar reviewed Aug 23, 2024
View reviewed changes
README.md Show resolved Hide resolved
@klueska klueska force-pushed the add-custom-config branch 4 times, most recently from b35495c to 8c7fb88 Compare August 26, 2024 12:45
pohly
pohly requested changes Aug 27, 2024
View reviewed changes
api/example.com/resource/gpu/v1alpha1/sharing.go Outdated Show resolved Hide resolved
api/example.com/resource/gpu/v1alpha1/validate.go Outdated Show resolved Hide resolved
cmd/dra-example-kubeletplugin/cdi.go Show resolved Hide resolved
cmd/dra-example-kubeletplugin/driver.go Outdated Show resolved Hide resolved
cmd/dra-example-kubeletplugin/state.go Outdated Show resolved Hide resolved
cmd/dra-example-kubeletplugin/state.go Outdated Show resolved Hide resolved
@klueska klueska force-pushed the add-custom-config branch 4 times, most recently from dc8ae4d to 800cb26 Compare August 27, 2024 18:23
pohly
pohly requested changes Aug 28, 2024
View reviewed changes
api/example.com/resource/gpu/v1alpha1/api.go Outdated Show resolved Hide resolved
api/example.com/resource/gpu/v1alpha1/sharing.go Outdated Show resolved Hide resolved
api/example.com/resource/gpu/v1alpha1/sharing.go Outdated Show resolved Hide resolved
api/example.com/resource/gpu/v1alpha1/sharing.go Show resolved Hide resolved
cmd/dra-example-kubeletplugin/state.go Outdated Show resolved Hide resolved
cmd/dra-example-kubeletplugin/state.go Show resolved Hide resolved
cmd/dra-example-kubeletplugin/state.go Outdated Show resolved Hide resolved
@klueska klueska force-pushed the add-custom-config branch 4 times, most recently from 7020cf8 to 2a330b8 Compare August 28, 2024 17:32
pohly
pohly requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly okay.

I think it's worthwhile to explain some of the if checks a bit for those developers who study the code and are not intimately familiar with the DRA API semantics.

api/example.com/resource/gpu/v1alpha1/api.go Show resolved Hide resolved
cmd/dra-example-kubeletplugin/state.go Outdated Show resolved Hide resolved
cmd/dra-example-kubeletplugin/state.go Outdated Show resolved Hide resolved
cmd/dra-example-kubeletplugin/state.go Show resolved Hide resolved
cmd/dra-example-kubeletplugin/state.go Show resolved Hide resolved
cmd/dra-example-kubeletplugin/state.go Outdated Show resolved Hide resolved
@klueska klueska force-pushed the add-custom-config branch from 2a330b8 to 780ee5c Compare August 29, 2024 10:39
@klueska klueska force-pushed the add-custom-config branch from 780ee5c to dfc6542 Compare August 30, 2024 08:29
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elezar, klueska, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [elezar,klueska,pohly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@klueska
Copy link
Contributor Author

klueska commented Aug 30, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4269e61 into kubernetes-sigs:main Aug 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly requested changes

@elezar elezar elezar approved these changes

@bart0sh bart0sh Awaiting requested review from bart0sh

@byako byako Awaiting requested review from byako

Assignees

@pohly pohly

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@klueska @k8s-ci-robot @pohly @elezar